Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update baseline LRG selection #723

Merged
merged 6 commits into from May 5, 2021
Merged

Update baseline LRG selection #723

merged 6 commits into from May 5, 2021

Conversation

rongpu
Copy link
Contributor

@rongpu rongpu commented May 4, 2021

This PR updates the baseline LRG selection (assuming it will be the final main survey selection). Changes from SV3 include:
* Change the zfiber faint limit from 21.7 to 21.6
* Change the low-z limit from z>0.3 to z>0.4
* Change the overall density from 800/sq.deg. to 600/sq.deg.
* Remove the LRG_LOWDENS target bit

@rongpu rongpu requested a review from geordie666 May 4, 2021 22:42
@coveralls
Copy link

coveralls commented May 4, 2021

Coverage Status

Coverage decreased (-0.02%) to 59.193% when pulling fd0c8ea on rongpu-lrg into e59fc85 on master.

@geordie666
Copy link
Contributor

@rongpu: This all looks good to me, so no need for a detailed review.

One request. Can you update the docstring in isLRG() from:

- Current version (03/31/21) is version 15 on `the SV3 wiki`_.

to

- Current version (05/04/21) is version 254 on `the wiki`_.

Also, I think we can remove the LRG_LOWDENS bits from the bit-mask yaml file, as those bits have never been used in official Main Survey target catalogs. If you like, I can deprecate those in my working branch, though.

@geordie666
Copy link
Contributor

Thanks! I'll merge once tests pass.

@rongpu
Copy link
Contributor Author

rongpu commented May 4, 2021

Thanks @geordie666. I've made the change in the docstring.

And yes, if you could remove the LRG_LOWDENS bits from the yaml file that would be great.

@geordie666 geordie666 merged commit 05db498 into master May 5, 2021
@geordie666 geordie666 deleted the rongpu-lrg branch May 5, 2021 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants