support skybricks3 fz instead of gz files #730
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@sbailey: In about 20 minutes I'm going to tag desitarget |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR updates desitarget.skybricks to support the skybricks/v3 format which now uses fits.fz files instead of .fits.gz, while still being backwards compatible with the v2 fits.gz files. See $DESI_ROOT/target/skybricks/v3 .
~1/1500 current sky catalog locations are rejected by skybricks/v3 (down from ~1/300 in v2), with the locations that they disagree upon having a small positive flux bias. That's curious but hardly our biggest problem right now. v3 is distinctly better than v2 but needs this code update to use them.