New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add option to use Gaia EDR3 when selecting GFAs #734
Conversation
…ORITY, allow this behavior to be turned off
…revent updating Gaia DR2 columns unless there's new information
….e. base seeds on HEALPixels), particularly now that fiberassign has co-opted the original seeds
…DEC are defined in URAT
…R3; always need to pass dr kwarg to Gaia functions
…urces trickle into the EDR3 GFA catalog
… before and ON that isodate, in addition to the default of strictly before
@ameisner: This PR should update the GFAs to swap Gaia EDR3 information for DR2 information. The GFA files should now also include a I've created a full set of output files in |
@ameisner: Before you check this, I just realized that for the sources that match the sweeps, I wound the coordinates back to a So, currently, in my test files, the Gaia-only sources are actually at a
Do you have a preference between 1. or 2.? |
…5.5 to reflect the data model
@ameisner: I have now aligned everything in the new GFA files to Again, it would be excellent if you could check that those files meet your desiderata. |
@geordie666 thanks for all of these updates! Really sorry that I didn't see this pull request (GitHub notifications don't go to my e-mail inbox for some reason). I'll run some checks on your new GFA files later today / this evening. |
@geordie666 I ran a bunch of checks on your new eDR3 'gfas' files, and didn't find anything that I consider problematic. So these updates are good from my perspective. Looping over all 768 files, the two unique REF_CAT values were G3 and T2, and all G3 cases had REF_EPOCH = 2015.5. This all made sense to me. The one thing that caught my eye was that in the rare cases where REF_CAT = T2, GAIA_PHOT_G_MEAN_MAG is populated (apparently with Tycho V) even though GAIA_PHOT_G_N_OBS = 0. I can make sure that this won't be an issue for the fiberassign variability flagging I plan to do. I did also notice that this update to eDR3 made the 'gfas' catalogs such that Gaia placeholder values are always zeros, rather than a mixture of zeros and NaN's as in the 1.0.0 version of these files. That's also fine with me. Thanks again! |
Thanks, Aaron. Yes, I subconsciously added the overwrite to fix the mix of NaNs and zeros! I'll merge this soon. |
This PR is focused on updating the GFA targets to use Gaia EDR3.
It also adds a handful of requested features and bug fixes, which include:
SUBPRIORITY
value in target files with better-constructed random seeds.desitarget.io.write_*
routines alter the value ofSUBPRIORITY
, and including a keyword option to turn that overwriting behavior off.leq
kwarg when reading ledgers with a specificisodate
.isodate
.