Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

override_subpriority support duplicate TARGETID inputs #743

Merged
merged 2 commits into from May 28, 2021
Merged

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented May 28, 2021

This PR adds support for duplicate TARGETID inputs in override_subpriority, while still using the faster geomask.match function when the inputs are unique. Duplicates can occur in secondary programs when more than one secondary matches a primary. Includes unit tests.

@sbailey
Copy link
Contributor Author

sbailey commented May 28, 2021

Secondary run completes with

P=/global/cscratch1/sd/adamyers/ADMsecondary/outdata/1.0.1.dev5024/priminfo-dr9-1.0.1.dev5024/

select_secondary $P $CSCRATCH --scnddir /global/cscratch1/sd/adamyers/ADMsecondary \
--dark-subpriorities /global/cfs/cdirs/desi/target/catalogs/subpriority/fba-version-4.0.0/subpriorities-dark.fits \
--bright-subpriorities /global/cfs/cdirs/desi/target/catalogs/subpriority/fba-version-4.0.0/subpriorities-bright.fits

@coveralls
Copy link

coveralls commented May 28, 2021

Coverage Status

Coverage increased (+0.04%) to 58.948% when pulling 0b3a7f5 on secondsubprio into 5c84622 on master.

@sbailey sbailey merged commit 8fcbb4a into master May 28, 2021
@sbailey sbailey deleted the secondsubprio branch May 28, 2021 18:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants