Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Turn off the MWS_FAINT target classes. #748

Merged
merged 4 commits into from May 30, 2021
Merged

Turn off the MWS_FAINT target classes. #748

merged 4 commits into from May 30, 2021

Conversation

geordie666
Copy link
Contributor

This PR turns off all aspects of the MWS_FAINT_* target classes, including:

  • No longer setting any of the MWS_FAINT target bits.
  • No longer exempting MWS_FAINT from forced ledger TIMESTAMPs. There's no need to anymore.
  • Removing special logic that had been added to merge MWS_FAINT with secondary targets.

In the end, we decided that this was the simplest way to make progress because we were in a bind after not starting the Main Survey with the MWS_FAINT target classes. The problem was that if we included MWS_FAINT targets they would occasionally be merged with secondary targets that had previously matched a different target, which would update the behavior of fiberassign. If we attempted to prevent the MWS_FAINT targets from merging with secondary targets, we would produce duplicate targets with the same TARGETID, and TARGETID needs to be unique to track targets downstream of desitarget.

We will revisit the MWS_FAINT target classes as a pure secondary class during the summer shutdown.

I'll merge this as soon as tests pass as I'll need to tag new versions of the Main Survey targets.

@geordie666 geordie666 merged commit afd0160 into master May 30, 2021
@geordie666 geordie666 deleted the ADM-no-mwsF branch May 30, 2021 03:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant