Turn off the MWS_FAINT target classes. #748
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR turns off all aspects of the
MWS_FAINT_*
target classes, including:MWS_FAINT
target bits.MWS_FAINT
from forced ledger TIMESTAMPs. There's no need to anymore.MWS_FAINT
with secondary targets.In the end, we decided that this was the simplest way to make progress because we were in a bind after not starting the Main Survey with the
MWS_FAINT
target classes. The problem was that if we includedMWS_FAINT
targets they would occasionally be merged with secondary targets that had previously matched a different target, which would update the behavior of fiberassign. If we attempted to prevent theMWS_FAINT
targets from merging with secondary targets, we would produce duplicate targets with the sameTARGETID
, andTARGETID
needs to be unique to track targets downstream ofdesitarget
.We will revisit the
MWS_FAINT
target classes as a pure secondary class during the summer shutdown.I'll merge this as soon as tests pass as I'll need to tag new versions of the Main Survey targets.