Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update the data model for Main Survey MTL #755

Merged
merged 6 commits into from Jun 19, 2021
Merged

Conversation

geordie666
Copy link
Contributor

This PR tweaks the data model and directory structures for MTL files related to the Main Survey. It:

  • Fixes a bug to allow all types of MTL ledgers to be read, including SV3 and Main Survey 1.0.0 ledgers.
  • Changes the location of the "ZTILE" file (i.e. the file that includes zdone=True/False decisions) for the Main Survey:
    • For iterations of SV, this file was located at $ZCAT_DIR/tiles.csv
    • For the Main Survey, it will be located at $MTL_DIR/../ops/tiles-specstatus.ecsv (i.e. in the ops directory that is parallel to the mtl directory in the surveyops svn trunk).
  • Includes a workaround to process SV3 files that have fibermaps corresponding to the Main Survey.
    • PLATE_RA and PLATE_DEC were added to fibermaps when we started observing main tiles, but during the sv3->main transition, some zbest- files in sv3 also included these added columns.

I will need to test this PR once Stephen and Julien have the tiles-specstatus.ecsv file in place in svn, so I'm leaving it as a Work In Progress for now.

@geordie666 geordie666 added the WIP Work in Progress; don't merge yet label Jun 17, 2021
@coveralls
Copy link

coveralls commented Jun 18, 2021

Coverage Status

Coverage decreased (-0.09%) to 58.667% when pulling bdba75f on ADM-new-MTL-model into f394557 on master.

@geordie666 geordie666 merged commit b197fda into master Jun 19, 2021
@geordie666 geordie666 deleted the ADM-new-MTL-model branch June 19, 2021 16:55
@geordie666 geordie666 removed the WIP Work in Progress; don't merge yet label Jun 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants