New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add secondaries to MTL ledgers without merging with primaries #764
Conversation
…h primaries as far as reading the secondary files
…rging with primaries
…hould never be merged with primaries
…t up code to append new secondary targets to ledgers
…date make_initial_ledger script to facilitate appending to ledgers
Basic usage, as an aide-memoire:
|
The outputs from using this approach with the
for the output target files and:
for the updated/appended to ledgers. I'm setting this to a WIP, both to give people time to vet these files and as I just realized that I'll now need to update the MTL loop to look for the |
Minor update: After further consideration, I realized that I don't actually need to update the MTL loop to look for the To help with fba testing, I've mocked up a version of the file structure for added secondary targets (and actually added the added secondary targets!). The relevant MTL directory is:
and I've added a link farm that looks like |
This PR sets up the infrastructure for (occasionally) adding new secondary targets without merging with primary targets. A guiding principle is that the new secondaries will always have a different
TARGETID
to prevent their behavior ever affecting a primary (and vice-versa). The PR includes:RR_LYRAE
andMWS_FAINT_*
secondary targets.secondary.select_secondary()
to completely ignore primary targets, if requested.OVERRIDE
target.TARGETID
is created based on writing secondaries to amain2
directory.TARGETID
can never duplicate a previously used primary or secondaryTARGETID
.add_secondary_no_merge
script to runsecondary.select_secondary()
without considering primaries.io.write_mtl()
.append
option in themake_initial_ledger
script.Also, along for the ride, I fixed a minor bug when reading headers of
.ecsv
files with the functionio.read_ecsv_header()
. That function was reading information about columns prior to the official header information, now it strictly extracts only dictionaries after themeta
keyword.