Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code typos #770

Merged
merged 3 commits into from Nov 8, 2021
Merged

fix code typos #770

merged 3 commits into from Nov 8, 2021

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Nov 8, 2021

Fix 4 instances of variable names typos in cuts.py (probably most are harmless)

@coveralls
Copy link

coveralls commented Nov 8, 2021

Coverage Status

Coverage remained the same at 57.299% when pulling ed73324 on typo_fixes into 1bf3e0c on master.

@geordie666
Copy link
Contributor

Thanks, Sergey. As you noted, most of these typos are in clauses that we don't actually trigger in the code. Some of the clauses were set up in a certain, formulaic way to facilitate working with mocks as well as with the real data.

The only typo that, I suppose, could have been harmful is the gaiamag = gaiagmag.copy() line. But, I think that will just lead to warnings on comparisons to NaN rather than affecting the actual selection.

In any case, feel free to merge this small PR after documenting it in doc/changes.rst.

@segasai segasai merged commit f7aef60 into master Nov 8, 2021
@segasai
Copy link
Contributor Author

segasai commented Nov 8, 2021

Done.
Thanks, Adam.

@geordie666 geordie666 deleted the typo_fixes branch October 6, 2022 21:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants