Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extra functionality for splitting random catalogs by HEALPixel #785

Merged
merged 5 commits into from Jan 13, 2022

Conversation

geordie666
Copy link
Contributor

This PR is an extension to #783.

Certain random catalogs already include an HPXPIXEL column, which #783 also added. This PR checks for the existence of an HPXPIXEL column before attempting to add it.

In addition, as random catalogs can be split in various ways, this PR adds a new directory name — based on the input random catalog filename — to the output HEALPixel-split directory structure. This makes it easier to track the location of — and better facilitates applying the desitarget.io reading routines to — HEALPixel-split random catalogs.

@geordie666
Copy link
Contributor Author

@ashleyjross: New versions of the HEALPixel-split randoms catalogs are available in:

/global/cscratch1/sd/adamyers/forashley/dr9/2.3.0.dev5334/randoms/resolve/randoms-1-*

These were built from the input catalogs:

/global/cfs/cdirs/desi/target/catalogs/dr9/0.49.0/randoms/resolve/randoms-1-*

@coveralls
Copy link

coveralls commented Dec 24, 2021

Coverage Status

Coverage decreased (-0.04%) to 56.474% when pulling 6bc7af8 on ADM-more-hpx-rands into 2c4b585 on master.

@geordie666
Copy link
Contributor Author

I'm going to merge this once tests pass. We can always revisit this later if the new style of random catalogs isn't as desired.

@geordie666 geordie666 merged commit ee9c805 into master Jan 13, 2022
@geordie666 geordie666 deleted the ADM-more-hpx-rands branch March 23, 2022 01:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants