New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Better functionality for fiber-based ToOs and ledger overrides #795
Conversation
…he number of allowed fibers (humans will handle that on a case-by-case basis)
…r than overwriting the ledger; create a separate ToO-fiber file for TOO_TYPE==FIBER targets
…o forcing all pixels if pixels aren't specified
…es that aren't due to tiles
…ges that aren't due to tiles
…f ledgers can only be processed when testing
…n in ledgers; update changes docs
@araichoor is checking the updates to the ToO mechanism from the fiberassign perspective. I'll likely merge this and cut a new desitarget tag once Anand is satisfied that everything gels. |
I ve coded up the twin PR in fiberassign, which works fine for the main survey tiles. one question though, when designing ToO-dedicated tile (maybe deprecated with the tertiary programs): in the current fiberassign code, for a ToO-dedicated tile, will read maybe it s fine, but I just wanted to mention. |
I think the case you describe is probably fine, Anand. I suspect we'll want to use the tertiary process in the future instead of I'm going to merge this soon and make a new tag of desitarget. I have lots of meetings today, but I'll try to have a tag ready as soon as possible. |
ok perfect then, thanks! |
This PR updates how ToOs with
TOO_TYPE=="FIBER"
are handled. It also adds some new functionality for the override ledgers that we use to modify targets that are already in the MTL ledgers.Updates to the ToO functionality include:
TIMESTAMP
s for earlier ToOs.ToO-fiber.ecsv
file is now created forTOO_TYPE==FIBER
ToOs.ToO.ecsv
file for backwards-compatibility.ToO.ecsv
file will include all of the ToO observations to-date in the Main Survey, which have solely beenTOO_TYPE==TILE
observations.TOO_TYPE=TILE
observations will be scheduled through the more-flexible tertiary process.TOO_PRIO==HI
observations are now forbidden forTOO_TYPE==FIBER
ToOs in the Main Survey.Updates to the override-ledger functionality include:
scnd-mtl-done-overrides.ecsv
andmtl-done-overrides.ecsv
are now created/updated when target states are forced into the MTL ledgers using the override process.scnd-mtl-done-tiles.ecsv
andmtl-done-tiles.ecsv
files, but have zeroed-out tile-based information (as when we force override information into the MTL ledgers, we don't use any tile-based redshifts).done-overrides
files can be used by the alt MTLs to determine when forced overrides occurred, if needed.