New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refresh test infrastructure #799
Conversation
@geordie666, I think I found the answer: pytest>=7 and pytest-cov>=4 give lower coverage than pytest<7; pytest-cov<4 which is what we have at NERSC. I've pinned to those older versions, and the coverage value now matches the NERSC value.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @weaverba137, I appreciate you running carefully through some of these abstruse cases. This all looks good to me, so feel free to merge when you're ready.
FYI (in case you were thinking of tagging now that tests pass): I'll need to make a couple of updates in the next few days to run randoms for DR10 of the Legacy Surveys. I'll make a new tag when I've completed those updates.
I don't actually need to tag this immediately, so go ahead and tag based on your own changes when you're ready. |
This PR closes #798 by refreshing the test infrastructure.