Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refresh test infrastructure #799

Merged
merged 11 commits into from Nov 21, 2022
Merged

Refresh test infrastructure #799

merged 11 commits into from Nov 21, 2022

Conversation

weaverba137
Copy link
Member

This PR closes #798 by refreshing the test infrastructure.

@weaverba137 weaverba137 self-assigned this Nov 18, 2022
@coveralls
Copy link

coveralls commented Nov 18, 2022

Coverage Status

Coverage increased (+11.6%) to 56.294% when pulling dd577ce on refresh-tests into c5e89fa on main.

@weaverba137 weaverba137 added the WIP Work in Progress; don't merge yet label Nov 18, 2022
@weaverba137
Copy link
Member Author

@geordie666, I think I found the answer: pytest>=7 and pytest-cov>=4 give lower coverage than pytest<7; pytest-cov<4 which is what we have at NERSC. I've pinned to those older versions, and the coverage value now matches the NERSC value.

desitarget/svX/svX_cuts.py is imported by importlib.import_module instead of a standard import statement, & this seems to be incompatible with how recent versions of pytest-cov counts coverage. Further research will be needed to fix this long-term, but for now pinning the versions works.

@weaverba137 weaverba137 removed the WIP Work in Progress; don't merge yet label Nov 21, 2022
Copy link
Contributor

@geordie666 geordie666 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @weaverba137, I appreciate you running carefully through some of these abstruse cases. This all looks good to me, so feel free to merge when you're ready.

FYI (in case you were thinking of tagging now that tests pass): I'll need to make a couple of updates in the next few days to run randoms for DR10 of the Legacy Surveys. I'll make a new tag when I've completed those updates.

@weaverba137
Copy link
Member Author

I don't actually need to tag this immediately, so go ahead and tag based on your own changes when you're ready.

@weaverba137 weaverba137 merged commit 73ee3fd into main Nov 21, 2022
@weaverba137 weaverba137 deleted the refresh-tests branch November 21, 2022 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Coverage of sv1, sv2, sv3 has dropped dramatically
3 participants