Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add nightwatch, desimeter, and parallel make #143

Merged
merged 3 commits into from Apr 25, 2020
Merged

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Apr 24, 2020

This PR adds nightwatch and desimeter to the list of known packages, and adds -j 8 to the make install command for compiled codes so that they compile faster in parallel (spexec in particular).

Note: nightwatch doesn't actually support python setup.py install yet, but this gets a placeholder ready in desiInstall for if/when nightwatch is ready to be installed.

@weaverba137
Copy link
Member

This looks fine, but let me do a quick check for other packages we might want to include. It's been a long time since that list was updated.

@weaverba137
Copy link
Member

'templates': 'https://desi.lbl.gov/svn/code/spectro/templates',

I'm pretty sure that's out of date.

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Candidates for inclusion on the list:

  • prospect : no setup.py yet, but it is turning into a genuine Python package.
  • desicmx : maybe???

Candidates for removal:

  • desimodules : on the list for historical reasons. It is now installed in a completely different way, and intentionally maintained "by hand".
  • desici : Is anyone still using this?
  • two_percent_DESI : Inactive since 2018.
  • speclite : We usually pip install this in a desiconda environment.
  • desiAdmin : This will never be installed with desiInstall
  • Everything in svn/code/spectro

Everything else I think can legitimately stay.

@sbailey
Copy link
Contributor Author

sbailey commented Apr 24, 2020

Thanks for checking those.

Adding prospect sounds good (in the same spirit as adding nightwatch: getting desiInstall ready for when those packages catch up with a setup.py)

desicmx and desici are both sandbox repos for sharing code, but not intended to be installed as formal packages, so they don't need to be included.

yes, templates is out of date and can be dropped from the desiInstall list.

Also ok to drop the others you listed as candidates for removal. Can you take care of updating those before merging? thanks.

@weaverba137
Copy link
Member

Done. Please do a final check and merge when tests are done.

@sbailey
Copy link
Contributor Author

sbailey commented Apr 25, 2020

List of packages added and removed looks fine, but can you check what happened with the travis tests?

@weaverba137
Copy link
Member

weaverba137 commented Apr 25, 2020 via email

@weaverba137
Copy link
Member

Fixed. Merging now.

@weaverba137 weaverba137 merged commit 654b05e into master Apr 25, 2020
@weaverba137 weaverba137 deleted the installstuff branch April 25, 2020 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants