New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add nightwatch, desimeter, and parallel make #143
Conversation
This looks fine, but let me do a quick check for other packages we might want to include. It's been a long time since that list was updated. |
I'm pretty sure that's out of date. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Candidates for inclusion on the list:
- prospect : no setup.py yet, but it is turning into a genuine Python package.
- desicmx : maybe???
Candidates for removal:
- desimodules : on the list for historical reasons. It is now installed in a completely different way, and intentionally maintained "by hand".
- desici : Is anyone still using this?
- two_percent_DESI : Inactive since 2018.
- speclite : We usually pip install this in a desiconda environment.
- desiAdmin : This will never be installed with
desiInstall
- Everything in svn/code/spectro
Everything else I think can legitimately stay.
Thanks for checking those. Adding prospect sounds good (in the same spirit as adding nightwatch: getting desiInstall ready for when those packages catch up with a setup.py) desicmx and desici are both sandbox repos for sharing code, but not intended to be installed as formal packages, so they don't need to be included. yes, templates is out of date and can be dropped from the desiInstall list. Also ok to drop the others you listed as candidates for removal. Can you take care of updating those before merging? thanks. |
Done. Please do a final check and merge when tests are done. |
List of packages added and removed looks fine, but can you check what happened with the travis tests? |
It’s checking for the presence of particular packages. Easy fix. But
cooking now.
On Fri, Apr 24, 2020 at 17:15 Stephen Bailey ***@***.***> wrote:
List of packages added and removed looks fine, but can you check what
happened with the travis tests?
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub
<#143 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AA43AUXKFSSSE5FRRFSAVB3ROITTRANCNFSM4MQO43FA>
.
--
--
With great responsibility seldom comes great power.
|
Fixed. Merging now. |
This PR adds nightwatch and desimeter to the list of known packages, and adds
-j 8
to themake install
command for compiled codes so that they compile faster in parallel (spexec in particular).Note: nightwatch doesn't actually support
python setup.py install
yet, but this gets a placeholder ready in desiInstall for if/when nightwatch is ready to be installed.