Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub actions #156

Merged
merged 11 commits into from Dec 11, 2020
Merged

GitHub actions #156

merged 11 commits into from Dec 11, 2020

Conversation

weaverba137
Copy link
Member

This PR

  • Fixes Don't assume master is default branch #154
    • The cost of eliminating master is that all branches must be explicitly labeled as such. For example desiInstall desiutil branches/main. Exception: desiInstall foo trunk is an abbreviation for desiInstall foo branches/trunk.
    • This may require updates to e.g. integration tests that install (checkout/clone) from scratch into a clean environment. However, I think the desispec nightly integration test doesn't actually do that, it just updates existing checkouts, right?
  • Also implements GitHub Actions for desiutil.
    • However, tests of desiutil against Astropy 2.0.x are abandoned because it is not worth finding a compatible version of healpy that compiles in the GitHub environment.

@weaverba137 weaverba137 self-assigned this Dec 10, 2020
Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great. The GitHub Actions are a breath of fresh air. I tested desiInstall for a tag and a branch and both worked. Minor items for consideration but not blocking factors for merging:

  • Consider shortening the names of the tests in .github/workflows/python-package.yml. When viewing the summary of tests in the github PR interface, the right side is getting cutoff (e.g. "CI / Check code style; allow failures. (ubuntu-latest, 3.8) (pull_request) Suc") even when I have the browser window maximally wide on my laptop, and the interface doesn't provide a horizontal slider. I presume that if the test failed it would be flagged obviously, but short names would help, e.g. something like "test", "coverage", "docs", "style".
  • very minor: could "desiInstall (package) main" be a shortcut for "desiInstall install branches/main" similar to "desiInstall (package) trunk"?

@weaverba137
Copy link
Member Author

@sbailey, good suggestions. I'll get those in before merging.

@weaverba137
Copy link
Member Author

@sbailey, do you have other significant changes to desiutil planned for release 20.12? If not, I can tag desiutil after this merge.

@sbailey
Copy link
Contributor

sbailey commented Dec 11, 2020

No other planned changes for desiutil for 20.12; please tag after merging. Thanks.

@weaverba137 weaverba137 merged commit 65975ce into master Dec 11, 2020
@weaverba137 weaverba137 deleted the github-actions branch December 11, 2020 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't assume master is default branch
2 participants