Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add a function that converts SFD EBV to 'true' EBV #166

Closed
wants to merge 1 commit into from

Conversation

segasai
Copy link
Contributor

@segasai segasai commented Mar 15, 2021

Hi,

To address issues raised here
desihub/desispec#1159

I've added a function that converts SFD EBV to 'true' EBV, in order to avoid having a 0.86 normalization number in multiple places.

(To avoid possible problems related to diving by .86 instead of multiplying, I explicitly take input EBVs rather than just return the normalization number.)

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.01%) to 68.032% when pulling c862240 on dust_sfd_function into 3ce49f0 on master.

@sbailey
Copy link
Contributor

sbailey commented Mar 16, 2021

After the 0.1% run is over (next week?) @julienguy and @schlafly will standardize our desitutil.dust calculations and merge this 0.86 factor internally so that the user doesn't have to do it externally (which would likely result in some users not knowing to do so). Let's not merge this PR yet; they can decide if they want to build on on this PR or do it separately.

I do like the spirit of corrected_ebv = function(sfd_ebv) to avoid multiply vs. divide confusion.

@weaverba137
Copy link
Member

This PR is superseded by #169.

@julienguy
Copy link
Contributor

Closing because superseded by more recent PR.

@julienguy julienguy closed this May 13, 2021
@weaverba137 weaverba137 deleted the dust_sfd_function branch June 4, 2021 03:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants