Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add the option of computing the MW dust transmission in the WISE bands #175

Merged
merged 6 commits into from Aug 2, 2021
Merged

add the option of computing the MW dust transmission in the WISE bands #175

merged 6 commits into from Aug 2, 2021

Conversation

moustakas
Copy link
Member

A simple extension of #169 to support the WISE bands.

@coveralls
Copy link

coveralls commented Aug 2, 2021 •
edited

Coverage Status

Coverage increased (+0.01%) to 66.654% when pulling 83e5b73 on wise-dust into d413957 on master.

@moustakas
Copy link
Member Author

At least one of the failing tests appears to be the same astropy issue identified in desihub/speclite#67.

@moustakas moustakas mentioned this pull request Aug 2, 2021
Closed
weaverba137
weaverba137 approved these changes Aug 2, 2021
View reviewed changes
Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks fine to me. Merge when ready.

@moustakas moustakas merged commit ee25edc into master Aug 2, 2021
@moustakas moustakas deleted the wise-dust branch August 2, 2021 19:09
@rfinn rfinn mentioned this pull request Jun 3, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@weaverba137 weaverba137 weaverba137 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@moustakas @coveralls @weaverba137