add_dependencies includes envvars #183
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
weaverba137
approved these changes
Jan 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses desihub/desispec#1077 by adding the following environment variables to the suite of dependencies added by
desiutil.depend.add_dependencies:this expands the concept of "dependencies" to be not just code versions but also input directories. This list can be overridden with
envvar_namesoption analogous to pre-existingmodule_namesoption.I will make a companion PR on desispec to make sure we call this for every
desispec.io.write*function, but this PR doesn't need to wait for that.@weaverba137 if you have a chance to take a look, please do, but I plan to merge later today when I get to the point of needing this for testing.