[WIP] Updates to desiInstall #185
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbailey
approved these changes
Aug 15, 2022
There was a problem hiding this comment.
Looks good, thanks. I tested with installing desispec 0.54.0 twice into the same location with
desiInstall -r $SCRATCH/temp desispec 0.54.0
desiInstall -v -F -r $SCRATCH/temp desispec 0.54.0
It successfully removed and replaced the previous installation without complaint.
|
@weaverba137 feel free to merge when ready; I left this open in case you were doing any additional operational testing. |
|
I do have a bit more testing to do, but I hope to merge in another day or so. |
|
Merging now so we can also fix #187. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR:
Some operational testing is needed before merging.