Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Add method for compiling code in a branch #188

Merged
merged 7 commits into from
Aug 18, 2022
Merged

[WIP] Add method for compiling code in a branch #188

merged 7 commits into from
Aug 18, 2022

Conversation

weaverba137
Copy link
Member

This PR closes #186.

@sbailey, I've done one test so far, but I'd like to have more people testing this before merging.

On NERSC/perlmutter, desiutil/main already points to this branch.

@coveralls
Copy link

coveralls commented Aug 18, 2022

Coverage Status

Coverage increased (+0.2%) to 71.013% when pulling bc34890 on build_ext into 4f910f4 on main.

@weaverba137
Copy link
Member Author

Code is now updated as requested, as is fiberassign. Please test again.

Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Works great, thanks!

@sbailey sbailey merged commit 27697a3 into main Aug 18, 2022
@sbailey sbailey deleted the build_ext branch August 18, 2022 22:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

desiInstall of specex/main and fiberassign/main, which need compilation too
3 participants