Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update permission settings when installing #195

Merged
merged 3 commits into from
Jun 1, 2023
Merged

Update permission settings when installing #195

merged 3 commits into from
Jun 1, 2023

Conversation

weaverba137
Copy link
Member

This PR:

Summarizing changes to desiInstall:

  • Module files will always be installed world-read.
  • Software files will be installed world-read, and user,group-read-only, unless:
    • --no-world is specified, in which case world-read is disabled.
    • A branch is installed, including main, in which case user-write is enabled.
  • Internally, fix_permissions.sh is no longer used. In fact, no external scripts or unix commands are used to change permissions.

@weaverba137 weaverba137 requested a review from sbailey May 23, 2023 22:56
@weaverba137 weaverba137 self-assigned this May 23, 2023
@coveralls
Copy link

coveralls commented May 23, 2023

Coverage Status

Coverage: 74.392% (+0.6%) from 73.826% when pulling 94c1025 on install-world into a15f4f9 on main.

Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thanks. I empirically tested that the new desiInstall behavior works as advertised (and that it matches what we intend for sharing code installations publicly).

@sbailey sbailey merged commit e5a3a2f into main Jun 1, 2023
24 checks passed
@sbailey sbailey deleted the install-world branch June 1, 2023 22:17
@weaverba137 weaverba137 mentioned this pull request Jun 7, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants