Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Func Fits: Weights and bug fix #30

Merged
merged 2 commits into from Apr 10, 2016
Merged

Func Fits: Weights and bug fix #30

merged 2 commits into from Apr 10, 2016

Conversation

profxj
Copy link
Contributor

@profxj profxj commented Apr 10, 2016

Enables use of weights
Fixes a bug in final fit

@sbailey sbailey merged commit 94cd69c into master Apr 10, 2016
@sbailey sbailey deleted the func_fit branch April 10, 2016 19:32
@weaverba137
Copy link
Member

In the future, can you please insist that all PRs on desiutil include an update to changes.rst prior to merging? That or only let me do all PR merges.

@sbailey
Copy link
Contributor

sbailey commented Apr 11, 2016

Thanks for the reminder. "git log --oneline" can help retroactively figure out what should have been in changes.rst, but it is less human-readable than a curated changes.rst . Directly editing docs/changes.rst via the github can be a lightweight way of adding a comment if one initially forgot.

@weaverba137
Copy link
Member

In this case git log --oneline gives "weights and mask". Not very enlightening.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants