Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Desiconda version directories #77

Merged
merged 12 commits into from Jul 12, 2017
Merged

Conversation

weaverba137
Copy link
Member

I am creating this Pull Request to start discussion. Don't merge until we've reached consensus on how all the pieces work together. Additional commits may be required.

See also desihub/desimodules#9.

@weaverba137 weaverba137 self-assigned this Jul 11, 2017
@sbailey
Copy link
Contributor

sbailey commented Jul 12, 2017

Looks good with the caveat that I haven't tried running it myself. If this was used to create the installations in the following directories, then fine with me to merge. Thanks.

/global/common/cori/contrib/desi/desiconda/startup/modulefiles
/global/common/cori/contrib/desi/desiconda/20170613-1.1.4-spectro

I have tested these with:

module use /global/common/cori/contrib/desi/desiconda/startup/modulefiles
module load desimodules/17.6

export DESI_SPECTRO_REDUX=$SCRATCH/desi/spectro/redux
export SPECPROD=dailytest
export PIXPROD=dailytest
export DESI_SPECTRO_SIM=$SCRATCH/desi/spectro/sim
export DESI_SPECTRO_DATA=$SCRATCH/desi/spectro/sim/$PIXPROD

python -m desispec.test.old_integration_test

and also loading just desiconda without any other desi code:

module use /global/common/cori/contrib/desi/desiconda/current/modulefiles
module load desiconda

@weaverba137
Copy link
Member Author

I'm still finding a few typos, so not ready to merge quite yet.

@weaverba137
Copy link
Member Author

I was able to install desimodel/1.9.5 via desiBootstrap.sh, so I'm satisfied that this is working.

@weaverba137 weaverba137 merged commit 195ca13 into master Jul 12, 2017
@weaverba137 weaverba137 deleted the desiconda-version-directories branch July 12, 2017 21:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants