Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Signal-to-noise ratio of narrow-line emission #124

Closed
yuvoonng opened this issue May 2, 2023 · 4 comments
Closed

Signal-to-noise ratio of narrow-line emission #124

yuvoonng opened this issue May 2, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@yuvoonng
Copy link

yuvoonng commented May 2, 2023

When FastSpecFit calculates the uncertainty of the amplitude, for spectra with narrow-line emission, it only uses a few pixels, which might lead to underestimating the uncertainty. As shown in the attached file, they do not appear as strong in the spectra as calculated.
sn_amp2.pdf
sn_amp.pdf

@moustakas
Copy link
Member

Thank you for the ticket @yuvoonng.

Here are some notes I sent on Slack, which I'm copying for reference:

Thank you, I agree that 4 pixels is definitely not sufficient for determining the scatter in the pixels. By default, the code uses the pixels that are +/-3*sigma of the line-center and only falls back to 4 pixels when the line is very narrow. When I was developing this part of the code, I thought this choice would be sufficient and would only affect a small fraction of objects/lines, but this is obviously. pretty important for a narrow-line sample like yours.

In the meantime I have a few suggestions:

  • One, you could spin through the spectra and remeasure the scatter in the (emission-line subtracted) spectrum using a larger window (maybe 10 pixels or so would be sufficient?).
  • Second, you could investigate using a combination of S/N on the amplitude and the flux to flag actual non-detections.
  • Or, third, we could fix this in the code and then refit all the objects in your sample.
  • Your idea here!

@moustakas moustakas self-assigned this May 3, 2023
@moustakas moustakas added the bug Something isn't working label May 3, 2023
@moustakas
Copy link
Member

@yuvoonng I'd like to address this issue soon. Do you have a sense of whether 10 pixels or so is sufficient for estimating the uncertainty in the continuum level around the narrow lines you've been studying?

@yuvoonng
Copy link
Author

@moustakas Upon investigation for some sources, 10 pixels are sufficient to estimate the signal-to-noise ratio. Thank you.

@moustakas
Copy link
Member

Addressed in #137.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
No open projects
Development

No branches or pull requests

2 participants