Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow the Redrock redshift to be overridden #115

Merged
merged 7 commits into from Apr 12, 2023
Merged

Conversation

moustakas
Copy link
Member

For many applications it is useful to be able to override the redshift inferred by Redrock, e.g., to use VI redshifts. This PR adds the hooks necessary to support these redshifts (written in the context of the DESI-2 / tertiary programs).

@coveralls
Copy link

coveralls commented Apr 11, 2023

Pull Request Test Coverage Report for Build 4677422349

  • 5 of 25 (20.0%) changed or added relevant lines in 2 files are covered.
  • 2 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.2%) to 50.429%

Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/io.py 2 9 22.22%
py/fastspecfit/fastspecfit.py 3 16 18.75%
Files with Coverage Reduction New Missed Lines %
py/fastspecfit/fastspecfit.py 2 13.27%
Totals Coverage Status
Change from base Build 4588352494: -0.2%
Covered Lines: 2236
Relevant Lines: 4434

💛 - Coveralls

@moustakas moustakas merged commit a019bc3 into main Apr 12, 2023
8 checks passed
@moustakas moustakas deleted the input-redshifts branch April 12, 2023 11:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants