Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add support for DR10 photometry #133

Merged
merged 35 commits into from Aug 2, 2023
Merged

add support for DR10 photometry #133

merged 35 commits into from Aug 2, 2023

Conversation

moustakas
Copy link
Member

This PR generalizes the handling of the Legacy Surveys photometry to handle DR9 as well as DR10 (input) photometry.

@moustakas
do not assume primary ext is named PRIMARY
70f69a3
@moustakas
generalize dr9dir to legacysurveydir; see desihub/desispec#2079
b4be813
@moustakas
fix tests
63d6902
@moustakas
test against desispec/main
c89bc28
@moustakas
new _gather_photometry method
c029bbd
@moustakas
use FPHOTO_DIR env
85d3a7f
@moustakas
pass specprod
81b138a
@moustakas
propagate photorelease deeper
04783d1
@moustakas
add dr9,dr10 yaml files
4c0141d
@moustakas
use yaml file to specify input photometry; big refactor starting
aad192a
@moustakas
move desiutil.dust methods to util
1d11795
@moustakas
more generalization
52bd099
@moustakas
generalize flux units, output table columns
a739d97
@moustakas
continuum_specfit done
6bf1e9c
@moustakas
emlines and qa refactor done
6aa165f
@moustakas
use importlib.resources.files
4a54acc
@moustakas
generalize mwdust_transmission by filtername
a82bcbe
@moustakas
works end-to-end
fd2004e
@moustakas
pass minmax spec,phot wavelengths as optional inputs
363e95a
@moustakas
bug: input_redshifts when building qa
d920894
@moustakas
fix --verbose option in fastspec and fastphot
3981cc0
@moustakas
by default only plot emission lines with snrcut>1
fd0b12f
@moustakas
actually make emline_snrmin an optional input with default zero
9d30a16
@moustakas
add nsmoothspec optional input
44cf562
@moustakas
add no smooth continuum option
f7af0b8
@moustakas
make qa aware of no smooth continuum
ef91102
@moustakas
cleanup util.mwdust_transmission
6a0e5ba
@moustakas moustakas mentioned this pull request Jul 19, 2023
Closed
@coveralls
Copy link

coveralls commented Aug 2, 2023 •
edited

Pull Request Test Coverage Report for Build 5740736605

  • 211 of 368 (57.34%) changed or added relevant lines in 6 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-0.1%) to 51.599%
Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/util.py 7 10 70.0%
py/fastspecfit/emlines.py 7 11 63.64%
py/fastspecfit/continuum.py 62 90 68.89%
py/fastspecfit/io.py 116 155 74.84%
py/fastspecfit/fastspecfit.py 16 99 16.16%
Files with Coverage Reduction New Missed Lines %
py/fastspecfit/continuum.py 2 73.09%
py/fastspecfit/fastspecfit.py 5 13.43%
Totals Coverage Status
Change from base Build 5740706159: -0.1%
Covered Lines: 2436
Relevant Lines: 4721
💛 - Coveralls

@moustakas moustakas merged commit cec13e9 into main Aug 2, 2023
8 checks passed
@moustakas moustakas deleted the dr10 branch August 2, 2023 15:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
No open projects
EDR FastSpecfit VAC
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@moustakas @coveralls