Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

2.3.1 release candidate #148

Merged
merged 33 commits into from
Aug 19, 2023
Merged

2.3.1 release candidate #148

merged 33 commits into from
Aug 19, 2023

Conversation

moustakas
Copy link
Member

This PR includes a variety of fixes and updates and is a 2.3.1 release candidate.

Highlights include:

  • Bug fix from 2.3.0 tests when one or more cameras on the first spectrum in a given healpixel is fully masked.
  • Restore support for fitting stacked spectra (totally broken in 2.3.0.
  • Restore the xtol convergence criterion parameter in scipy.optimize.least_squares from 1e-2 to its default (1e-8) to prevent the optimization from stopping before actual convergence. One example where this matters is sv3-bright-25918-39627758090851408. I also removed the requirement that the final velocity widths and centers cannot change by more than +/-20% during the final round of fitting. I found that objects like sv3-bright-25918-39627758090851408 require the additional flexibility after some of the constraints are relaxed in the final iteration. I will need to do some additional larger-scale tests to ensure this change doesn't introduce other problems, however.
  • The _FLUX and _FLUX_IVAR parameters are now derived using the method documented in
    Equivalent width uncertainties are significantly lower in v2 #127 (comment). See the full thread in Equivalent width uncertainties are significantly lower in v2 #127 for additional details and caveats regarding these parameters.
  • After investigating some of the objects with broad line-emission documented in Fastspecfit V2.0 does not detect many Broad-Ha candidates that were originally detected in V1.0 #118 and comparing the fitting results with low-mass, narrow-line galaxies with no AGN, I decided to restore the requirement that at least one of the two reddest broad Balmer lines (e.g., Halpha or Hbeta) must be detected with S/N>3. (More documentation and testing to follow.)
  • As requested in Wish list of outputs for a QSO VAC #112, He II 1640 and Al III 1857 have been added to the default data model. (The 1450, 1700, 3000 A continuum luminosities were added in updates and bug fixes ahead of next version of VACs #145).
  • The emission-line parameter file is now an optional input, in order to allow for custom fitting.
  • Various documentation and web-app updates.

@coveralls
Copy link

coveralls commented Aug 14, 2023

Pull Request Test Coverage Report for Build 5859917529

Details

  • 167 of 250 (66.8%) changed or added relevant lines in 5 files are covered.
  • 407 unchanged lines in 3 files lost coverage.
  • Overall coverage decreased (-0.01%) to 60.0%

Changes Missing Coverage Covered Lines Changed/Added Lines %
py/fastspecfit/fastspecfit.py 4 8 50.0%
py/fastspecfit/emlines.py 40 52 76.92%
py/fastspecfit/io.py 20 40 50.0%
py/fastspecfit/continuum.py 101 148 68.24%
Files with Coverage Reduction New Missed Lines %
py/fastspecfit/emlines.py 1 51.31%
py/fastspecfit/io.py 187 54.72%
py/fastspecfit/continuum.py 219 72.95%
Totals Coverage Status
Change from base Build 5812793938: -0.01%
Covered Lines: 2454
Relevant Lines: 4090

💛 - Coveralls

@moustakas moustakas merged commit 87227fb into main Aug 19, 2023
8 checks passed
@moustakas moustakas deleted the 2.3.1-candidate branch August 19, 2023 15:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants