Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

more flexible line-fitting++ #15

Merged
merged 24 commits into from Apr 10, 2021
Merged

more flexible line-fitting++ #15

merged 24 commits into from Apr 10, 2021

Conversation

moustakas
Copy link
Member

[WIP] This PR adds:

  • Fixes for cascades;
  • Adds MgII and several other nebular lines ([Ne V], [Ne III], [SIII], etc.);
  • Allows the forbidden and Balmer line-widths and velocity centroids to be different, which can be separate from MgII, which is yielding some very interesting (useful!) results;
  • By default, iterates the line-fitting in order to support the preceding step.

There is a computational penalty to the code changes in this PR but on-balance they are in the right direction for numerous applications, including data-driven and target-specific improvements of the redrock templates.

@moustakas moustakas merged commit 27b3282 into main Apr 10, 2021
@moustakas moustakas deleted the flexible-lines branch April 10, 2021 01:55
@moustakas
Copy link
Member Author

Tested with three deep tiles of each targeting flavor, 80607 (QSO+LRG), 80608 (ELG), and 80613 (BGS+MWS), totaling about 10,000 spectra and (separately) broadband photometry fitted.

Bone-simple visualizations are here--
https://data.desi.lbl.gov/desi/users/ioannis/fastspecfit/cascades/

and merged fitting results are here--
/global/cfs/cdirs/desi/spectro/fastspecfit/cascades/tiles/merged
https://data.desi.lbl.gov/desi/spectro/fastspecfit/cascades/tiles/merged/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant