Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

command line interface #105

Merged
merged 14 commits into from Mar 22, 2018
Merged

command line interface #105

merged 14 commits into from Mar 22, 2018

Conversation

forero
Copy link
Member

@forero forero commented Mar 21, 2018

This addresses #89 and dissolves #23 . Fiberassign uses now a command line interface

Using the files in /global/cscratch1/sd/forero/fibertest the new interface can be tested as:

fiberassign -mtl mtl.fits -sky sky.fits -star star.fits -surveytiles surveytiles.txt -outdir ./ -footprint tile.fits -positioners /global/common/cori/contrib/desi/desiconda/20170613-1.1.4-spectro/code/desimodel/0.9.0/data/focalplane/fiberpos.txt -fibstatusfile fiberstatus.ecsv 

or by setting another run date

fiberassign -mtl mtl.fits -sky sky.fits -star star.fits -surveytiles surveytiles.txt -outdir ./ -footprint tile.fits -positioners /global/common/cori/contrib/desi/desiconda/20170613-1.1.4-spectro/code/desimodel/0.9.0/data/focalplane/fiberpos.txt -fibstatusfile fiberstatus.ecsv -rundate 2010-02-21

@forero forero requested review from sbailey and rncahn March 21, 2018 18:15
Copy link
Contributor

@sbailey sbailey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay for command line options to control the different input files locations. Thanks.

For standardization with other desi code, I updated it to use double-hyphens for long-name options, e.g. --outdir instead of -outdir etc.

However, it could still be useful to have an optional config file with the ability to specify these parameters, including the ones that are now in Feat::Feat(). e.g. we will especially want to experiment with different densities of standard stars and sky fibers.

I'll merge this for now and open a new ticket about re-introducing a lighter-weight and optional features file.

@sbailey sbailey merged commit 1a45bf5 into master Mar 22, 2018
@sbailey sbailey deleted the newinterface branch March 22, 2018 18:26
@sbailey sbailey mentioned this pull request Mar 22, 2018
This was referenced Mar 22, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants