standard star DESI_TARGET mask as input option #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbailey
requested changes
May 15, 2018
There was a problem hiding this comment.
Thanks for adding this option. We will have more than one bit that could be use for standard stars (e.g. F-stars and WD), so please update this to be a --starmask instead of a single --starbit. Default 60129542144 = 0xe00000000 = STD_FSTAR, STD_WD, STD_BRIGHT. Also use OBSCONDITIONS to match whether this stdstar target is allowed to be used on this tile, just like science targets do.
|
@sbailey I've implemented the |
|
I am going to merge this now. Basic tests confirm that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This solves #64 by introducing the command line option
--starbitto select the bit in thedesi_targetmask that signals a standard star. The default option is33.