fix POTENTIAL table #156
Merged
fix POTENTIAL table #156
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello @sbailey , yes the available targets HDU now looks good in master branch. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes #155 where the assigned TARGETID for each fiber didn't appear in the potential assignments list for each fiber. It was a side affect of PR #147 that ensured that the FIBERASSIGN HDU output was sorted by TARGETID.
I also added a check in
qa-fiberassignthat would have caught this.@tskisner a new fiberassign run of the 18.11 target list is in /global/cscratch1/sd/sjbailey/desi/fiberassign/18.11-redo . Please check whether those potential assignments more closely match what you have in the tsk_refactor branch.