Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Sort by FIBER; set sciencemask et al by name or number even for SV #208

Merged
merged 4 commits into from Jun 24, 2019

Conversation

sbailey
Copy link
Contributor

@sbailey sbailey commented Jun 24, 2019

This PR adds a few features used by the Survey Validation Data Challenge:

  • sort output by FIBER (even though downstream code shouldn't care about the fiber order, it currently does care)
  • allow setting sciencemask etc. by name in addition to number, including for SV target catalogs
  • There were also some updates to how it parses fiberassign options into fba_run and fba_merge_results options, which might make that slightly more maintainable by making it opt-in instead of opt-out.

@sbailey sbailey requested a review from tskisner June 24, 2019 21:27
@tskisner
Copy link
Member

This looks good, thanks!

@sbailey sbailey merged commit 765d467 into master Jun 24, 2019
@sbailey sbailey deleted the sv branch June 24, 2019 22:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants