Implement field rotation #219
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…oughout the API. Propagate the rotation information from the input tiles to the output. Many unit tests are commented out while I debug a potential issue with the upstream desimodel focalplane. [ci skip]
|
This work is now ready. The unit test for the field rotation compares the petal assignments before and after a field rotation of 36 degrees (i.e. one petal location). This test does not pass due to the previously implemented "tie breaking" of assignment order based on fiber ID rather than device location. See section of code here: https://github.com/desihub/fiberassign/blob/master/src/assign.cpp#L332-L339 This was implemented to agree with a previous version of the code, but we can throw that away at this point. I verified that if I switch back to using location for tie-breaking then the rotated assignment matches. I am not changing the algorithm in this PR, since it makes more sense to do it as part of #179, #183, and #184. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DO NOT MERGE THIS PR. I am still debugging an issue that may be due to an error in the upstream desimodel focalplane theta / phi ranges.