Support supplemental sky targets #241
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I will rebase this and resolve the recently introduced conflict, but it would be good to merge this soon since it touches many files. @geordie666 and @Srheft , let me know when there are SUPP_SKY target files "in the wild" that have the SUPP_SKY bit set and the SKY bit un-set. |
|
The travis failure is fixed in #246. Will rebase this again after that is merged. |
…his is needed since we want this target type to count towards the per-petal sky assignment totals. Add suppsky targets to unit tests.
|
@tskisner: The latest /project/projectdirs/desi/target/catalogs/dr8/0.35.1/skies/skies-supp have the necessary changes to the |
|
OK, perfect. Merging now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds support for a new target type (
SUPPSKY). These targets are assigned after normalSKYtargets in order to meet the per-petal sky budget requirement. The unit tests verify that in the case of under-dense sky targets, the suppsky targets are used instead. See attached plot generated by the unit tests (blue == normal sky, cyan == suppsky).This support in fiberassign requires that input targets can be differentiated between sky and suppsky. I believe that current target files in use make this challenging (by setting both
SKYand 'SUPP_SKY` target bits).This PR should not be merged until that issue is clarified.