Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

remove -Wstrict-prototypes #309

Merged
merged 2 commits into from Feb 11, 2021
Merged

remove -Wstrict-prototypes #309

merged 2 commits into from Feb 11, 2021

Conversation

marcelo-alvarez
Copy link
Contributor

This branch corrects a distutils bug that adds spurious -Wstrict-prototypes flag when compiling c++ extensions, by removing the flag in setup.py.

@sbailey
Copy link
Contributor

sbailey commented Feb 11, 2021

On travis the -Wstrict-prototypes flag wasn't there, causing a test build failure when trying to remove it. Added a check and retrying.

@sbailey sbailey merged commit f9bb7c8 into master Feb 11, 2021
@sbailey sbailey deleted the strict-prototype branch February 11, 2021 22:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants