New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Mtltime timestamp #347
Mtltime timestamp #347
Conversation
@geordie666 : Aside comment: with checking how the MTL ledgers reading cuts on the isodate, I see that it is now a "<" cut: https://github.com/desihub/desitarget/blob/b86ae8ebf61024e310e5d102723191d5f23d4007/py/desitarget/io.py#L2552-L2557 |
|
I'll add the "<=" kwarg when I add the LyA decisions for the full Main Survey MTL loop, though. |
thanks for adding a "<=" option in reading the mtl; that simplifies things on the fba_launch side (otherwise, I don t know if there corner case issues with adding a fraction of second to args.mtltime when reading the isodate0. |
I think this looks OK, now. I'm sure we'll find a few bugs as we work towards the new MTL loop, though! |
I pushed a last commit, triggered by a calm re-reading of the function.
should we merge? |
This PR now defaults the args.mtltime fba_launch argument to the latest timestamp in the $DESI_SURVEYOPS/mtl-done-tiles.ecsv file for the considered args.program.
If no value is found, we default to the current time.
We currently add +1min to the MTL latest timestamp to account for current discrepancy between mtl-done-tiles.ecsv and the ledgers.
To be seen how to change that once the fix is done in desitarget
Besides, we did a black formatting of fba_launch.