Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

handle failures to find new dark calibrations #379

Closed
sybenzvi opened this issue Jan 24, 2024 · 1 comment
Closed

handle failures to find new dark calibrations #379

sybenzvi opened this issue Jan 24, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request
Projects

Comments

@sybenzvi
Copy link
Contributor

Update run_preproc (and possibly run_qproc) to handle new behavior of desispec towards darks. When a suitable dark cal is not found, the new desispec default is to throw an exception rather than quietly fall back to an older dark. This can be overriden by passing fail_on_dark_not_found=False to preproc.

See details in the PR desispec#2162.

@sybenzvi sybenzvi added the enhancement New feature or request label Jan 24, 2024
@sybenzvi sybenzvi added this to Needs triage in Nightwatch via automation Jan 24, 2024
@sybenzvi sybenzvi moved this from Needs triage to High priority in Nightwatch Jan 24, 2024
@sybenzvi
Copy link
Contributor Author

Looking at how preproc is called in run_preproc (see run.py), I think we may not need any changes to be compatible with the desispec update. The new desispec will raise an exception if the command-line option --fail-on-dark-not-found is passed. So if we don't change anything, we default to the older behavior that does not raise an exception.

Nightwatch automation moved this from High priority to Closed Jan 25, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
Development

No branches or pull requests

2 participants