-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Only add 2nd Best Fit option if it actually exists #100
Conversation
Agree with the change (and removed arg Now I understand what happened: indeed you had I took this opportunity to remove this hard-coding. I tested the pages quite extensively, on my side it's ok now. |
.. But please check one last time on your notebook! |
Testing now. If all goes well, I'll merge shortly. |
Tests look good, so I will merge momentarily. |
This PR fixes #98.
When Prospect is used with SDSS data or data derived from SPARCL, a 2nd best fit model is not available. However,
ViewerWidgets.add_model_select()
was assuming that it was always available based onwith_full_2ndfit
which defaults toTrue
.This resulted in the JavaScript side of prospect attempting to obtain data from an object that is
null
(a PythonNone
converted to JavaScript).With this change, the argument
with_full_2ndfit
is unused, can it be eliminated from that method entirely?