Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Scripts n doc #48

Merged
merged 6 commits into from Sep 9, 2020
Merged

Scripts n doc #48

merged 6 commits into from Sep 9, 2020

Conversation

armengau
Copy link
Collaborator

Probably not ready yet

armengau and others added 6 commits July 4, 2020 08:49
@armengau
Copy link
Collaborator Author

@weaverba137 This is a to merge my current branch with your recent merge, better to do it now.

  • "Adding scripts and docs" is not fully achieved yet (some script but not the doc yet)
  • Recent change wrt bokeh: changed all widgetboxes to Column, to comply with bk 2.1 (says widgetboxes are going to be deprecated). It seems to be ok on html pages.

@weaverba137
Copy link
Member

@armengau , I'm not entirely sure I understood your previous comment. Are you saying this PR is ready for final review and merge with master?

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything here looks fine. I would recommend checking the Column -> widgetbox change against plotspecutils.py, where I already made that change. I seem to recall it was a very similar change, but it might help to keep the change consistent.

@armengau armengau merged commit 38d3e9c into master Sep 9, 2020
@armengau armengau deleted the scripts_n_doc branch September 9, 2020 14:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants