Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't use mask information to mark bad pixels in SDSS. #94

Merged
merged 3 commits into from Jan 24, 2024

Conversation

weaverba137
Copy link
Member

This PR closes #92.

As a stretch goal for this PR: are there ever cases where we want to mask DESI pixels above and beyond cases were inverse variance == 0? Are there some cases where a mask value should be ignored, versus "definitely do not use this pixel, even if inverse variance != 0", or somewhere in between?

@weaverba137 weaverba137 self-assigned this Jan 23, 2024
@coveralls
Copy link

coveralls commented Jan 23, 2024

Coverage Status

coverage: 2.032% (-0.004%) from 2.036%
when pulling 338e80c on sdss-masking
into 9710948 on main.

@sbailey
Copy link
Collaborator

sbailey commented Jan 24, 2024

I believe for DESI, all specmask bits are treated as bad and already have ivar=0 set too. I haven't traced it back in the code where this might be enforced, but that seems to be true from spot checking coadds. None-the-less, Redrock also specifically sets ivar=0 for any mask!=0 (redrock/external/desi.py L428), which might just be a belt-and-suspenders extra step.

For context, this is different for the fiberstatus mask, which has informative but non-fatal bits like RESTRICTED and POORPOSITION.

@weaverba137
Copy link
Member Author

@sbailey, thank you. I will not make any changes to DESI masking for the purposes of this PR, but I will add a condensed version of your reply in a comment.

@weaverba137 weaverba137 merged commit 6a4ccbe into main Jan 24, 2024
10 checks passed
@weaverba137 weaverba137 deleted the sdss-masking branch January 24, 2024 16:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Review masking of SDSS pixels
4 participants