Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gui cosmetics #97

Merged
merged 6 commits into from Feb 7, 2024
Merged

Gui cosmetics #97

merged 6 commits into from Feb 7, 2024

Conversation

armengau
Copy link
Collaborator

@armengau armengau commented Feb 6, 2024

  • Color option for the main curves (coadded spectrum and noise, model)
  • Improved widget layout when --no_vi_widgets is requested (which is the case of the interface to legacyviewer)
  • Added a TextInput to select a spectrum

@coveralls
Copy link

coveralls commented Feb 6, 2024

Coverage Status

coverage: 2.014% (-0.01%) from 2.024%
when pulling c69ef0e on gui-cosmetics
into 445d05d on main.

@armengau
Copy link
Collaborator Author

armengau commented Feb 6, 2024

About the color option: eg. plotspectra(colors=['black', 'blue', 'orange'])
or prospect_pages --colors black blue orange
changes the colors of the coadded spectra, "model", and coadded noise vectors respectively.

  • This makes it as simple as possible for the user to choose colors.
  • No option to change the colors of single-arm spectra, as their color codes is not arbitrary but associated to blue, red and NIR (plus they're less used)

Copy link
Member

@weaverba137 weaverba137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see any issues with this PR. I just had a minor comment on the change log.

doc/changes.rst Outdated Show resolved Hide resolved
@armengau armengau merged commit 6c1803b into main Feb 7, 2024
10 checks passed
@armengau armengau deleted the gui-cosmetics branch March 26, 2024 13:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants