add select_targetids optional input to results.read_zscan #289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sbailey
reviewed
Apr 1, 2024
py/redrock/results.py
Outdated
| @@ -104,14 +108,22 @@ def read_zscan(filename): | |||
| - zwarn: 0=good, non-0 is a warning flag | |||
|
|
|||
| """ | |||
| def encode_column(c): | |||
| return c.astype((str, c.dtype.itemsize)) | |||
There was a problem hiding this comment.
Is this a debugging leftover? Why is this function here, replacing the one imported via from .utils import encode_column. If we specifically need it here, please also copy the docstring.
There was a problem hiding this comment.
I honestly have no idea why I put this here (which was some time ago...). I'll remove it for this PR but if I figure out why I tripped on it in the first place I'll follow up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@sbailey this should be a non-controversial change, but it's needed as part of the Y3 template work.