Check for Nan in flux and ivar of spectra files #99
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This fixes issue #98 |
sbailey
reviewed
Feb 1, 2018
py/redrock/external/desi.py
Outdated
| # for entries with flux==0 | ||
| for i in np.where(isnan)[0] : | ||
| hdata[i][np.isnan(hdata[i])]=0. | ||
| hdata[i][np.isinf(hdata[i])]=0. |
There was a problem hiding this comment.
I think this could be handled more simply with:
bad = np.isnan(hdata) | np.isinf(hdata) | np.isneginf(hdata)
hdata[bad] = 0.0I'm more concerned with the assumption downstream that flux=0 data was actually bad data and should be set to ivar=0. Real data will very very rarely be exactly 0, but that seems fragile. Would be better to explicitly make a badflux mask like above, and then use that mask when loading the ivar HDU to set ivar[badmask]=0.
|
very well, I am redoing this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
set flux=0 ivar=0 to Nan or Inf values in spectra files when reading them.
checked it fixes the crash of one simulated spectra file in my sims.
now need to understand where this is coming from on the desispec side.