Incorporate sky into survey sims #76
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This looks ready to merge (once you update the changelog). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR uses the desisurvey.etc sky functionality added in desihub/desisurvey#129 to include the sky into the survey sims. This presently uses the simplest possible functionality, reproducing the existing behavior where the sky just scales the exposure factors by constants that depend on the DARK/GRAY/BRIGHT ephemerides definitions.
This PR presently has no appreciable impact on margins, since the changes end up being bookkeeping, though small differences occur because the sky may change during an exposure, which formerly was not part of the model.