Skip to content
This repository has been archived by the owner on Sep 3, 2020. It is now read-only.

Issues/827 front end testing #2

Merged
merged 17 commits into from Jul 20, 2018
Merged

Conversation

tstachl
Copy link
Contributor

@tstachl tstachl commented Jul 2, 2018

Loads of stuff in this pull request.

Removed unnecessary enum `PropertyType`
Fixed window size to viewport
Sped up slowMo mode
Connected browser console to process
Removed unnecessary enum `PropertyType`
Fixed window size to viewport
Sped up slowMo mode
Connected browser console to process
@tstachl tstachl self-assigned this Jul 2, 2018
const messages = core.Messages.loadMessages('@desklabs/scmt', 'test');
// const FIELDS = ['AccountRecordsFailed__c', 'AccountRecordsMigrated__c', 'AccountRecordsTotal__c', 'ArticleRecordsFailed__c', 'ArticleRecordsMigrated__c', 'ArticleRecordsTotal__c', 'AttachmentRecordsFailed__c', 'AttachmentRecordsMigrated__c', 'AttachmentRecordsTotal__c', 'CaseRecordsFailed__c', 'CaseRecordsMigrated__c', 'CaseRecordsTotal__c', 'ContactRecordsFailed__c', 'ContactRecordsMigrated__c', 'ContactRecordsTotal__c', 'InteractionRecordsFailed__c', 'InteractionRecordsMigrated__c', 'InteractionRecordsTotal__c', 'NoteRecordsFailed__c', 'NoteRecordsMigrated__c', 'NoteRecordsTotal__c', 'TopicRecordsFailed__c', 'TopicRecordsMigrated__c', 'TopicRecordsTotal__c', 'RecordsFailed__c', 'RecordsMigrated__c', 'RecordsTotal__c', 'Config__c', 'Desk_Config_Id__c', 'Desk_Endpoint__c', 'Error__c', 'JobId__c', 'Log__c', 'Mapping__c', 'Migration_Type__c', 'Object__c', 'StartDate__c', 'Status__c'];

export default class Run extends CommandBase {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm showing a problem in vscode with this line.

{ "resource": "/Users/khaver/code/salesforce/sfdx-plugin-scmt/src/commands/scmt/test/run.ts", "owner": "typescript", "code": "2417", "severity": 8, "message": "Class static side 'typeof Run' incorrectly extends base class static side 'typeof CommandBase'.\n Types of property 'flagsConfig' are incompatible.\n Type '{ endpoint: IOptionFlag<string>; username: IOptionFlag<string>; password: IOptionFlag<string>; mi...' is not assignable to type 'SfdxFlagsConfig'.\n Property 'endpoint' is incompatible with index signature.\n Type 'IOptionFlag<string>' is not assignable to type 'string | boolean | IBooleanFlag<any> | IOptionFlag<any> | JsonMap'.\n Type 'IOptionFlag<string>' is not assignable to type 'JsonMap'.\n Index signature is missing in type 'IOptionFlag<string>'.", "source": "ts", "startLineNumber": 13, "startColumn": 22, "endLineNumber": 13, "endColumn": 25 }

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kylehaver does it give a problem compiling or running?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have the same error, but it runs.

@kylehaver
Copy link
Member

The Article migration worked perfectly. However, I ran into an issue when running the case migration in StepThree. For contacts, the plugin maps the desk field Desk External Id to the Salesforce First Name field which causes the migration to fail after it is started.

image

I am testing with the zzz-scktmkb.desk.com site

Skeyelab
Skeyelab previously approved these changes Jul 5, 2018
Copy link
Contributor

@Skeyelab Skeyelab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

retracted. I am getting an error on cases

public static description = messages.getMessage('runCommandDescription');
public static examples = [
`$ sfdx scmt:test:run`,
`$ sfdx scmt:test:run -e https://domain.desk.com -n user@domain.com -p password`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I fixed this example. Other than that, LGTM

@Skeyelab
Copy link
Contributor

Skeyelab commented Jul 5, 2018

I am getting an error on mapping of cases.

Here is a screen recording: http://cloudapp.skeyelab.com/2o3H2N013o1k

ERROR running Run: TypeError: Cannot read property 'y' of null

@tstachl
Copy link
Contributor Author

tstachl commented Jul 5, 2018

@Skeyelab where does the error occur? I can't see it in your recording.

@tstachl
Copy link
Contributor Author

tstachl commented Jul 9, 2018

@Skeyelab please review again.

Copy link
Member

@kylehaver kylehaver left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes since I last reviewed look good. Tested article and kb migration and output folder was created and sshots taken.

@tstachl tstachl merged commit 7c29398 into master Jul 20, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants