Skip to content

Commit

Permalink
Revert "Fix build on MSVC 16.6.0."
Browse files Browse the repository at this point in the history
This reverts commit e4f4dad.

MSVC 16.6.* has a critical bug if Qt is compiled with it. See:

https://developercommunity.visualstudio.com/content/problem/1072443/
static-structs-with-atomics-initialization-regress.html
  • Loading branch information
john-preston committed Jun 16, 2020
1 parent b558136 commit eb97b77
Showing 1 changed file with 2 additions and 2 deletions.
4 changes: 2 additions & 2 deletions external/ranges/CMakeLists.txt
Original file line number Diff line number Diff line change
Expand Up @@ -19,8 +19,8 @@ else()
if (CMAKE_CXX_COMPILER_ID STREQUAL "MSVC")
target_compile_options(external_ranges
INTERFACE
/Zc:preprocessor # need for range-v3 see https://github.com/ericniebler/range-v3#supported-compilers
/wd5105 # needed for `/Zc:preprocessor`, suppressing C5105 "macro expansion producing 'defined' has undefined behavior"
/experimental:preprocessor # need for range-v3 see https://github.com/ericniebler/range-v3#supported-compilers
/wd5105 # needed for `/experimental:preprocessor`, suppressing C5105 "macro expansion producing 'defined' has undefined behavior"
)
endif()
endif()

0 comments on commit eb97b77

Please sign in to comment.