Minimize amount of code to rebuild when switching options

desktop-app · Sep 22, 2023 · 6de11e6 · 6de11e6
1 parent 28db382
commit 6de11e6
Show file tree

Hide file tree

Showing 3 changed files with 8 additions and 9 deletions.
diff --git a/CMakeLists.txt b/CMakeLists.txt
@@ -314,4 +314,11 @@ PRIVATE
     base/crash_report_writer.h
 )
 
+if (DESKTOP_APP_DISABLE_CRASH_REPORTS)
+    remove_target_sources(lib_base_crash_report_writer ${src_loc}
+        base/crash_report_writer.cpp
+        base/crash_report_writer.h
+    )
+endif()
+
 target_link_libraries(lib_base_crash_report_writer PUBLIC desktop-app::lib_base)
diff --git a/base/crash_report_writer.cpp b/base/crash_report_writer.cpp
@@ -6,8 +6,6 @@
 //
 #include "base/crash_report_writer.h"
 
-#ifndef DESKTOP_APP_DISABLE_CRASH_REPORTS
-
 #include "base/platform/base_platform_info.h"
 #include "base/integration.h"
 #include "base/crash_report_header.h"
@@ -460,5 +458,3 @@ std::optional<QByteArray> CrashReportWriter::readPreviousReport() {
 }
 
 } // namespace CrashReports
-
-#endif // DESKTOP_APP_DISABLE_CRASH_REPORTS
diff --git a/base/crash_report_writer.h b/base/crash_report_writer.h
@@ -6,8 +6,6 @@
 //
 #pragma once
 
-#ifndef DESKTOP_APP_DISABLE_CRASH_REPORTS
-
 #include "base/file_lock.h"
 
 namespace base {
@@ -37,6 +35,4 @@ class CrashReportWriter final {
 
 };
 
-} // namespace base
-
-#endif // DESKTOP_APP_DISABLE_CRASH_REPORTS
+} // namespace base