Allow disabling X11 desktop capturing independently. #107
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ilya-fedin
reviewed
Sep 13, 2022
ilya-fedin
reviewed
Sep 14, 2022
Squashed commit of the following:
commit 253b09a07520a3cecb3b88b2b7e8889ab3d9158d
Author: Hilton Chain <hako@ultrarare.space>
Date: Fri Sep 9 22:13:15 2022 +0800
Adapt the patch with cmake_dependent_option.
commit f6631bb43f353c9eafe1b1aba093e116518aa12a
Author: Esteve Varela Colominas <esteve.varela@gmail.com>
Date: Sun, 27 Jun 2021 23:57:04 +0200
Add -DTG_OWT_USE_X11
Allows disabling X11 desktop capturing independently of pipewire support, for
the few people that run wayland without any X11 support whatsoever.
This setup is untested, but supported by the GNI build system, see:
* src/modules/desktop_capture/BUILD.gn (option rtc_use_x11_extensions)
Toggling the WEBRTC_USE_X11 define also affects some files under
src/modules/audio_device, but that falls under "X11 support", regardless...
Use cmake_dependent_option to better declare variables that relate on other variables
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Squashed commit of the following:
commit 253b09a07520a3cecb3b88b2b7e8889ab3d9158d
Author: Hilton Chain hako@ultrarare.space
Date: Fri Sep 9 22:13:15 2022 +0800
commit f6631bb43f353c9eafe1b1aba093e116518aa12a
Author: Esteve Varela Colominas esteve.varela@gmail.com
Date: Sun, 27 Jun 2021 23:57:04 +0200