Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove debug logging from printDuration #31

Closed
jeffjose opened this issue Nov 7, 2020 · 2 comments
Closed

Remove debug logging from printDuration #31

jeffjose opened this issue Nov 7, 2020 · 2 comments

Comments

@jeffjose
Copy link

jeffjose commented Nov 7, 2020

Looks like printDuration has a debug logging in. See here

Reproduced below

String printDuration(Duration duration,
    {DurationTersity tersity = DurationTersity.second,
    DurationLocale locale = const EnglishDurationLocale(),
    String spacer,
    String delimiter,
    String conjugation,
    bool abbreviated = false}) {
  final String fmt = prettyDuration(duration,
      tersity: tersity,
      locale: locale,
      spacer: spacer,
      delimiter: delimiter,
      conjunction: conjugation,
      abbreviated: abbreviated);
  print(fmt);
  return fmt;
}
@jeffjose
Copy link
Author

jeffjose commented Nov 7, 2020

Opened #33 and #32

@tejainece
Copy link
Contributor

Guys what part of printDuration dont you understand. It is meant to print. If you just want to convet use prettyDuration. Also read the docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants