Fix terminateNotifications
#20
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
reviewed
Jun 6, 2022
| exports.Set(Napi::String::New(env, "showNotification"), Napi::Function::New(env, showNotification)); | ||
| exports.Set(Napi::String::New(env, "closeNotification"), Napi::Function::New(env, closeNotification)); | ||
| exports.Set(Napi::String::New(env, "requestNotificationsPermission"), Napi::Function::New(env, requestNotificationsPermission)); |
There was a problem hiding this comment.
Yes, it was duplicated… 🤦
This was referenced Jun 6, 2022
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR addresses two issues related to
terminateNotifications:terminateNotificationsimplementation for macOS.terminateNotificationsstill removed any pending notifications on Windows, which defeats the purpose of some of the changes in Add more control over notifications #13 about handling notifications from previous app sessions.These changes are needed in order to unblock desktop/desktop#14733, which basically fixes an issue where a process is not closed along with the rest of the app on Windows 10 (but not 11) due to our notifications code (probably, the COM server used to handle the notifications).