Only support the Windows 10 Creators Update and newer #22
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tidy-dev
reviewed
Jun 24, 2022
sergiou87
commented
Jun 24, 2022
lib/notification-support.ts
Outdated
| // Only Windows 10 and newer are supported | ||
| return majorVersion >= 10 | ||
| // Only Windows 10 (15063) and newer are supported | ||
| return majorVersion >= 10 && buildNumber >= CreatorsUpdateBuildNumber |
There was a problem hiding this comment.
Actually this is wrong… 🤦 it should be:
Suggested change
| return majorVersion >= 10 && buildNumber >= CreatorsUpdateBuildNumber | |
| return majorVersion > 10 || (majorVersion === 10 && buildNumber >= CreatorsUpdateBuildNumber) |
This was referenced Jun 24, 2022
Merged
Release 0.2.3
Merged
|
I made a mess with the temporary release 0.2.3 😓 I made another release 0.2.4 (first pre-release, then the actual release) with the fix in the check from fca5378. |
tidy-dev
approved these changes
Jun 29, 2022
sergiou87
added a commit
to desktop/desktop
that referenced
this pull request
Jun 29, 2022
This will disable desktop-notifications for Windows versions prior to the Creators Update (see desktop/desktop-notifications#22)
s7ab059789
pushed a commit
to s7ab059789/desktop
that referenced
this pull request
Sep 18, 2022
This will disable desktop-notifications for Windows versions prior to the Creators Update (see desktop/desktop-notifications#22)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
After investigating some issues in GitHub Desktop running on Windows Server 2016 (desktop/desktop#14714) it seems there are some limitations in Windows 10 prior to the Creators Update regarding the notifications API: https://docs.microsoft.com/en-us/uwp/api/windows.ui.notifications.toastnotification.tag?view=winrt-22621#remarks
I've changed a few things but it seems there is an important limitation in the notification payload, which makes it difficult for us to implement notifications as we'd like them.
Because of that, we're gonna support notifications from this
desktop-notificationslibrary on Windows 10 Creators Update and newer, while previous versions will rely on the HTML notifications API (just like W7 and W8 do nowadays, without the improvements from #13).