Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

UX: 'Create a branch' from another branch dialog #11440

Closed
staabm opened this issue Jan 22, 2021 · 1 comment
Closed

UX: 'Create a branch' from another branch dialog #11440

staabm opened this issue Jan 22, 2021 · 1 comment

Comments

@staabm
Copy link

staabm commented Jan 22, 2021

Describe the feature or problem you’d like to solve

when checking out a 'release branch', to create a new branch based on the currently checked out one (e.g. to build a hotfix for this release branch), github desktop opens a dialog with the 'master' branch pre-selected.

it requires an additional click to confirm the re-select the 'release branch'.

sometimes I don't notice that I need this additional click, start working in the newly created branch (which was mistakenly created based from 'master'). I finally realize that all my commits are based on the wrong branch when in the end of the process I open a PR which tells me that the target branch I originally had in mind has conflicts with my new hotfix-branch.

Current Dialog:

grafik

Note:

  • the currently select branch is 'DAIB_S024'
  • the pre-selected branch in the dialog is 'master'

Proposed solution

alternative A)

  • instead of a 'Create branch' button and the above 'branch chooser' we could have 2 buttons: one reading 'create branch from master' and another one 'create branch from $current-branch'

that way the button I am clicking also gives me an idea which path I have taken

alternative B)

  • preselect the previously selected branch (Current branch) instead of master
@steveward
Copy link
Member

Thanks for the issue @staabm. This has been previously discussed in #9845, and this comment specifically outlines the reasoning behind this decision.

At this time we don't have any plans to change this behavior. I'm going to close this issue out, but we'd still value feedback going forward about this decision and we do continue to evaluate issues even if they are closed. Thanks for using GitHub Desktop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants